Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Checkbox deprecation note #2492

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

httpsmenahassan
Copy link
Contributor

@httpsmenahassan httpsmenahassan commented Aug 1, 2023

Description

Replace reference to Input and ValidationFormGroup with Form.Checkbox within Checkbox docs

image

Deploy Preview

https://deploy-preview-2492--paragon-openedx.netlify.app/components/checkbox/

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 44d131d
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64cabe3d04d9e200088481f5
😎 Deploy Preview https://deploy-preview-2492--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (41f65ea) 91.39% compared to head (44d131d) 91.39%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2492   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         234      234           
  Lines        4161     4161           
  Branches     1001     1001           
=======================================
  Hits         3803     3803           
  Misses        351      351           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Replace reference to Input and ValidationFormGroup with Form.Checkbox within Checkbox docs
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@adamstankiewicz adamstankiewicz merged commit 8ae2fa8 into openedx:master Aug 3, 2023
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants